improve gateway symlink handling #6680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
fix/symlink-size
branch
from
829d639
to
80e0c47
Compare
hsanjuan
reviewed
Sep 27, 2019
| func (s *lazySeeker) Seek(offset int64, whence int) (int64, error) { | ||
| switch whence { | ||
| case io.SeekEnd: | ||
| return s.Seek(s.size+offset, io.SeekStart) |
There was a problem hiding this comment.
If we're seeking from the end, the offset will already be negative.
There was a problem hiding this comment.
Actually, this was wrong. It should have been Nvm. Seeking to the end is correctly done with a s.size-1+offset.Seek(-1, SeekEnd).
|
Build and tested with commit 361bb5f. |
Stebalien
force-pushed
the
fix/symlink-size
branch
2 times, most recently
from
18d1ab2
to
7a8e04e
Compare
Stebalien
force-pushed
the
fix/symlink-size
branch
from
7a8e04e
to
76b943b
Compare
Stebalien
force-pushed
the
fix/symlink-size
branch
from
76b943b
to
6f1204d
Compare
dirkmc
reviewed
Jan 3, 2020
|
Thanks for catching that (and bugging me to write a test)! |
|
(ok, there's definitely a bug here, I'll look into it when I get a chance) |
Fixes symlink sizes.
1. Require files to have known sizes. We can add support for unknown sizes _later_ but we can't use ServeContent for those files. 2. Replace the `sizeReadSeeker` with a `lazySeeker`. This one makes no assumptions about how it's used so we're less likely to run into weird bugs.
We should be _resolving_ symlinks (sometimes, still need to figure out when to do this WRT IPNS). However, that's a larger feature.
Stebalien
force-pushed
the
fix/symlink-size
branch
from
fe26806
to
c64eb11
Compare
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
improve gateway symlink handling This commit was moved from ipfs/kubo@ca2767a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This doesn't provide actual symlink support. The gateway treats symlinks
like text files.
fixes #6203